Collect all child nodes of lists and tables in StructTree #20327
+47
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| const element = new StructElementNode(this, dict); | ||
| map.set(dict, element); | ||
| switch (element.role) { |
There was a problem hiding this comment.
Please add a test to make sure that this behavior can't regress in the future.
timvandermeij
changed the title
|
I need to think about that: I'm not sure it's the right approach. |
|
Added a unit test case |
calixteman
reviewed
Oct 13, 2025
test/test_manifest.json
Outdated
| "lastPage": 1, | ||
| "type": "eq" | ||
| }, | ||
| { "id": "issue20324", |
There was a problem hiding this comment.
The changes in this file are useless.
There was a problem hiding this comment.
It was created running the add_test script so I thought it was needed somewhere. I'll revert it!
calixteman
reviewed
Oct 13, 2025
test/unit/api_spec.js
Outdated
| await loadingTask.destroy(); | ||
| }); | ||
|
|
||
| it("should collect all list and table items in StructTree", async function() { |
There was a problem hiding this comment.
Is there any specific reason to have this test in this file instead of struct_tree_spec ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix #20324
Tree nodes are collected bottom-up, so I think it is safe when a list or table item is collected, to collect its children too